Add Gomega HaveKeyWithValue #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarDarwish
changed the title
aelsabbahy
reviewed
Apr 22, 2017
resource/gomega.go
Outdated
|
|
||
| var key, val types.GomegaMatcher | ||
| for k, v := range valueI { | ||
| key, err = matcherToGomegaMatcher(k) |
There was a problem hiding this comment.
What does matcherToGomegaMatcher() on the key provide?
Can you give an example of this usage?
There was a problem hiding this comment.
No use because of constraints with YAML. Removed.
Merged
|
@aelsabbahy any updates with this PR and #233 #226? |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Add Gomega have-key-with-value * Don't convert have-key-with-value key to gomega * Fix unit test for have-key-with-value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my fork, I have an EC2 resource that returns a map of instance tags. This Gomega matcher allows you to do checks like the following: