Fix regression with silent format #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemounce
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
LGTM. @abrekhov, @aelsabbahy, I'm really sorry I missed that!
|
All good, thanks for the quick review. Waiting on travis, it has been taking a LONG long time to run builds lately. Just sits in the queue for 45m+. Hopefully, this build completes soon, then I'll merge/release. I'll migrate to travis-ci.com (from .org).. a random tweet makes me think it might fix the slowness issue. But, I'll wait until after this release to be on the safe side.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Fixes #656 656