New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action_on_circles seems to be broken #24

Closed

aelzenaar opened this issue Feb 12, 2024 · 1 comment

Labels

bug

Owner

aelzenaar commented Feb 12, 2024

The following is supposed to be the translates of the 2/3 cusp group's peripheral discs by elements of the group...

aelzenaar added the bug label

Owner Author

aelzenaar commented Feb 12, 2024 •

edited

Loading

To do:

add more rigorous unit tests for circle motions
modify conversion functions to and from P^4 to avoid large coordinates in # result vectors

Check if these make the position of the error obvious.

aelzenaar added a commit that referenced this issue


          Fix errors in action_on_circles and other, c.f. #24

86797a4

aelzenaar added a commit that referenced this issue


          Fix error in action_on_circles and add more tests, c.f. #24

d8a35fe

aelzenaar closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment