Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react fast refresh by reordering Vite React preamble script first #11

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Tyler-Brenneman
Copy link

Description

Fix React fast refresh script injection

Fixes #10

Additional context

Reorder injection to avoid error

Uncaught Error: @vitejs/plugin-react can't detect preamble. Something is wrong. See https://github.com/vitejs/vite-plugin-react/pull/11#discussion_r430879201

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Process and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@cshawaus cshawaus merged commit 4234ad2 into aem-vite:main Jun 21, 2024
7 checks passed
@cshawaus
Copy link
Contributor

@Tyler-Brenneman Thanks for this fix, surprised it never came up during my test, but good to see it fixed nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React fast refresh script error
2 participants