no_std support #21
Merged
no_std support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes regarding bytes-utils dependency are obsolete, as PR vorner/bytes-utils#3 has been already merged and published (v0.1.2) in the meanwhile. |
|
Hi @marius-meissner, thanks for doing this! Just a heads up, I probably won't have a chance to look at this until this weekend, but I'll post an update then once I have a chance to take a look. |
|
What is the status here? If I can support in any way, please let me know. |
marius-meissner
force-pushed
the
no_std_support
branch
from
312c214
to
0896620
Compare
|
Just rebased this PR to the latest main state. |
|
Hey @marius-meissner, apologies again for the really long delays here. I'm coming back around to updating this library, so I'll merge this and work it into a larger 5.0.0 release. Thanks again for your help and patience here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an awesome crate, but unfortunately fails to build on no_std projects.
This PR adds support for no_std builds by adding a std feature, which when is disabled enables no_std environments.
bytes-utils dependencyTo make this work, a similar change for bytes-utils was needed: vorner/bytes-utils#3.So I just pointed
Cargo.tomlto the PR forkFeel free to suggest another approach if you are not happy with that (e.g. pinning to hash, using dependency patch, just wait for the other PR, etc.).Code formatting
Seems
cargo fmtwas not executed for a while. So I skipped this step for not messing up this PR with code style changes.Circle CI
In my opinion, it makes sense to add a CI step to check for successful no_std builds.
Unfortunately, cargo always compiles dev dependencies, even for release builds. Cargo flag avoid-dev-deps is fixing this, but is still unstable. So the CI job is testing only nighly Rust for now.
Looking forward to your feedback!