Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should make it easier to edit things. #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tlevine
Copy link

@tlevine tlevine commented Nov 26, 2013

I made pre tag and script length counts get compiled automatically, and I added a couple of tests.

@aemkei
Copy link
Owner

aemkei commented Nov 26, 2013

Nice one, but some parts are a bit to much:

  • We should run test() on demand only. Otherwise it will break the local storage.
  • The first script should be the real one! < looks ugly here.
  • We don't care about the byte count inside the script tag.
  • Output in <pre> tag should be fixed width for better "readability". How about splitting the code?
  • Output of the byte count to console should be enough. Otherwise have to update the title, too.
  • <script> tag to compute all the stuff should be at the bottom.

@aemkei
Copy link
Owner

aemkei commented Nov 26, 2013

And sorry, but it might be a bit to late for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants