Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTL: Add support for "/libs/granite/sightly/templates/clientlib.html" #133

Closed
6 tasks done
deeprim opened this issue Sep 25, 2017 · 4 comments · Fixed by #205
Closed
6 tasks done

HTL: Add support for "/libs/granite/sightly/templates/clientlib.html" #133

deeprim opened this issue Sep 25, 2017 · 4 comments · Fixed by #205

Comments

@deeprim
Copy link
Collaborator

deeprim commented Sep 25, 2017

"/libs/granite/sightly/templates/clientlib.html" template should be proposed as data-sly-use option.

Once it selected in data-sly-use, it should be proposed in data-sly-call:

  • js
  • css
  • all

Once it selected in data-sly-call, corresponding "Template Arguments" should be proposed in data-sly-call options:

  • categories

For categories option clientlibs available in the project should be proposed as completion variants

  • Add /libs/granite/sighlty/templates/clientlib.html for data-sly-use completion
  • Add index for all clientlibs in the project
  • data-sly-call for clientlib.html should have completion for js & css
  • "Options" completion for either js or css should have categories as "top" variant
  • Completion for categories option should have all clientlibs available in project (clientlibs that have "embed" attribute should go first)
  • Quick doc action should be available for categories value (e.g. categories='<caret>my-cat'). The documentation should reveal all data regarding selected category
@dmitry-cherkas
Copy link
Contributor

I guess, it would be a better option to index all OOTB AEM templates and use this index for auto-suggest.

@deeprim
Copy link
Collaborator Author

deeprim commented Mar 26, 2018

Hi @dmitry-cherkas ,

Though, the indexing of OOTB AEM templates sounds like a good feature.
The specific semantics (the clientlibs template should be called with client libs, the category) could not be indexed, i.e. required to be implemented anyway

@deeprim deeprim added this to the v0.9.1 milestone Mar 26, 2018
@deeprim deeprim added this to To Do in HTL Mar 26, 2018
deeprim added a commit that referenced this issue Apr 2, 2018
deeprim added a commit that referenced this issue Apr 3, 2018
deeprim added a commit that referenced this issue Apr 3, 2018
deeprim added a commit that referenced this issue Apr 5, 2018
deeprim added a commit that referenced this issue Apr 16, 2018
deeprim added a commit that referenced this issue Apr 19, 2018
deeprim added a commit that referenced this issue Apr 22, 2018
@deeprim deeprim closed this as completed Apr 23, 2018
@deeprim deeprim moved this from To Do to In Progress in HTL Apr 23, 2018
deeprim added a commit that referenced this issue Apr 23, 2018
deeprim added a commit that referenced this issue Apr 23, 2018
@deeprim deeprim modified the milestones: v0.9.1, v0.9 Apr 26, 2018
DeusBit pushed a commit that referenced this issue May 13, 2018
(cherry picked from commit c1a78a8)
@deeprim deeprim modified the milestones: v0.9, v0.9.1 May 21, 2018
DeusBit added a commit that referenced this issue May 22, 2018
@deeprim deeprim moved this from In Progress to Done in HTL Jun 5, 2018
@deeprim deeprim reopened this Jul 11, 2018
@deeprim deeprim moved this from Done to In Progress in HTL Jul 11, 2018
@deeprim
Copy link
Collaborator Author

deeprim commented Jul 11, 2018

The completion is broken, reopened

@deeprim deeprim self-assigned this Aug 4, 2018
deeprim added a commit that referenced this issue Aug 7, 2018
@deeprim deeprim modified the milestones: v0.9.1, v0.9.2 Apr 14, 2022
@koha26 koha26 added this to Ready for development in Common May 13, 2022
@koha26 koha26 self-assigned this May 13, 2022
@koha26 koha26 moved this from Ready for development to In progress in Common May 14, 2022
koha26 added a commit that referenced this issue May 19, 2022
koha26 added a commit that referenced this issue May 19, 2022
@koha26
Copy link
Collaborator

koha26 commented May 19, 2022

@deeprim
I fixed documentation in scope of #205. In addition, I added documentation for categories, embeds, dependencies in the clientlibs folder.

Also, completion has been fixed in 07768bf commit.
Now, all items from the list in the description work as expected.

@koha26 koha26 moved this from In progress to Done in Common May 19, 2022
deeprim added a commit that referenced this issue May 20, 2022
#133 Fixed clientlibs category documentation in HTL, added for categories in clientlibs folder
@koha26 koha26 closed this as completed May 20, 2022
@koha26 koha26 moved this from Done to Archive in Common Jul 1, 2022
@koha26 koha26 moved this from In Progress to Done in HTL Jul 17, 2022
@koha26 koha26 moved this from Done to Archive in HTL Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment