Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGI: add validation of OSGi annotations #174

Closed
vhonchar opened this issue Jun 6, 2018 · 1 comment · Fixed by #197 or #199
Closed

OSGI: add validation of OSGi annotations #174

vhonchar opened this issue Jun 6, 2018 · 1 comment · Fixed by #197 or #199
Assignees
@koha26
Labels
Priority: Medium Status: Completed Type: Feature Type: Inspection
Projects
Common
Milestone
v0.9.2

Comments

@vhonchar
Copy link

vhonchar commented Jun 6, 2018

Sometime, there are situations, when developer can add service with metadata == true, but do not add any property. To avoid that, it is good to support such validation rules directly in Intellij.

Use case:

  1. Open any implementation of OSGi service
  2. Add property "metadata = true" into @component

Expected: line with component annotation should be highlighted as warning with appropriate message.

Note.
List of actual rules could be taken from maven-bundle-plugin.
@deeprim deeprim added this to the v0.9.2 milestone Jul 11, 2018
@koha26 koha26 added this to Ready for development in Common Apr 19, 2022
@koha26 koha26 self-assigned this Apr 21, 2022
@koha26 koha26 moved this from Ready for development to In progress in Common Apr 21, 2022
koha26 added a commit that referenced this issue Apr 22, 2022
@koha26
#174 Added inspection for Felix Component metatype attribute
09020cd
@koha26 koha26 linked a pull request Apr 22, 2022 that will close this issue
#174 Added inspection for Felix Component metatype attribute #197
Merged
deeprim added a commit that referenced this issue Apr 23, 2022
@deeprim
Merge pull request #197 from aemtools/174_felix_metatype_validation
e242435 
#174 Added inspection for Felix Component metatype attribute
@koha26 koha26 moved this from In progress to Done in Common Apr 23, 2022
koha26 added a commit that referenced this issue Apr 24, 2022
@koha26
#174 Fixed case when there are class level properties annotation
263e614
koha26 added a commit that referenced this issue Apr 24, 2022
@koha26
#174 Fixed case when there are class level properties annotation
e10e076
@koha26 koha26 moved this from Done to In progress in Common Apr 24, 2022
deeprim added a commit that referenced this issue Apr 24, 2022
@deeprim
Merge pull request #199 from aemtools/174_felix_metatype_validation
2e2bfe7 
#174 Fixed case when there are class level properties annotation
@koha26 koha26 linked a pull request Apr 25, 2022 that will close this issue
#174 Fixed case when there are class level properties annotation #199
Merged
@koha26
Copy link
Collaborator

koha26 commented Apr 25, 2022

Will be added in 0.9.2.

@koha26 koha26 closed this as completed Apr 25, 2022
@koha26 koha26 moved this from In progress to Done in Common Apr 26, 2022
@koha26 koha26 moved this from Done to Archive in Common Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koha26 koha26

Labels
Priority: Medium Status: Completed Type: Feature Type: Inspection
Projects
Common
Archive
Milestone
v0.9.2
3 participants
@deeprim @koha26 @vhonchar