cilium: enforce device detection and enable image building #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvaps
force-pushed
the
fix-external-traffc-policy
branch
from
5038a2c
to
9f955df
Compare
kvaps
force-pushed
the
fix-external-traffc-policy
branch
from
9f955df
to
750fe3a
Compare
|
TODO: should also handle cases when user specified |
themoriarti
reviewed
May 27, 2024
kvaps
force-pushed
the
fix-external-traffc-policy
branch
from
750fe3a
to
1058abe
Compare
kvaps
changed the title
externalTrafficPolicy: Cluster
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps
force-pushed
the
fix-external-traffc-policy
branch
from
1058abe
to
43f9540
Compare
themoriarti
approved these changes
May 27, 2024
|
Awesome patch. |
This was referenced May 29, 2024
Merged
This was referenced Jun 10, 2024
Merged
This was referenced Jun 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for
externalTrafficPolicy: ClusterSince cilium has no native method for dynamicaly configure the devices, we use bash script instead. For two reasons:
ovn0device start upThis PR includes the upstream fix:
https://github.com/aenix-io/cozystack/blob/750fe3a34afc5203dfec432684fa510210d5fd51/packages/system/cilium/patches/startup-script.patch
for more details see:
externalTrafficPolicy: Clusterin generic-veth chaining mode cilium/cilium#32714externalTrafficPolicy: Clusterand cilium kubeovn/kube-ovn#4089