Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship all logos with Cozystack #218

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Ship all logos with Cozystack #218

merged 1 commit into from
Jul 18, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Jul 16, 2024

Add all application logos into the cozystack container. Please merge it after #217

image

@kvaps kvaps marked this pull request as draft July 16, 2024 07:39
@kvaps kvaps changed the title logos Ship all logos with Cozystack Jul 16, 2024
@kvaps kvaps force-pushed the logos branch 3 times, most recently from 0e5cd5b to 114d5ab Compare July 16, 2024 08:33
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps marked this pull request as ready for review July 16, 2024 15:32
Copy link
Member

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an approach to deliver everything with cozystack packages is not very good, considering the large number of files that do not carry the direct functionality of the product, we still give customers the opportunity to download helm charts, images, etc. Why can't customers download images and other auxiliary files from another repository? There are specialized CDNs for such purposes. Therefore, it is possible to separate repositories of utilities, tools, image graphics, auxiliary files, articles, etc.

@kvaps
Copy link
Member Author

kvaps commented Jul 17, 2024

These logos are part of Helm charts delivered by cozystack container.
They are required to make Dashboard working in air-gaped installations.
Logos are in SVG and should not take much space.

Filally we want to make cozystack fully undepended from external sources, including docker images in the future.

@themoriarti
Copy link
Member

@kvaps But images is a part of dashboard, maybe we need store this logos in dashboard chart?

@kvaps
Copy link
Member Author

kvaps commented Jul 18, 2024

I thought about this, but it might be difficult to recompile dashboard image every time we need to add new logo and new Helm charts.

From the other side logos now stored in the same HTTP server with our Helm charts. Dashboard is useless in case it can't reach our HTTP server with Helm charts. So for dashbiard we need booth type of assets any way.

We have this HTTP server for all assets like helm-charts, grafana dashboards and now also logos.

Copy link
Member

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this incident of adding files that are not related to the functionality does not entail the addition of other files to the helm chart, then no, now I understand the approach. But I still recommended to physically store them in another repository and thus we can also download them for the HTTP server.

@themoriarti themoriarti merged commit 9bbdb11 into main Jul 18, 2024
@themoriarti themoriarti deleted the logos branch July 18, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants