Skip to content

Commit

Permalink
Remove unneeded deep copy
Browse files Browse the repository at this point in the history
  • Loading branch information
ilya-hontarau committed Mar 29, 2024
1 parent 71539c2 commit 133e1b4
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions internal/controller/factory/statefulset.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,25 +238,23 @@ func getLivenessProbe(probe *corev1.Probe) *corev1.Probe {
}

func mergeWithDefaultProbe(probe *corev1.Probe, defaultProbe corev1.Probe) *corev1.Probe {
res := defaultProbe.DeepCopy()

if probe == nil {
return res
return &defaultProbe
}

if probe.InitialDelaySeconds != 0 {
res.InitialDelaySeconds = probe.InitialDelaySeconds
defaultProbe.InitialDelaySeconds = probe.InitialDelaySeconds
}

if probe.PeriodSeconds != 0 {
res.PeriodSeconds = probe.PeriodSeconds
defaultProbe.PeriodSeconds = probe.PeriodSeconds
}

if hasProbeHandlerAction(*probe) {
res.ProbeHandler = probe.ProbeHandler
defaultProbe.ProbeHandler = probe.ProbeHandler
}

return res
return &defaultProbe
}

func hasProbeHandlerAction(probe corev1.Probe) bool {
Expand Down

0 comments on commit 133e1b4

Please sign in to comment.