Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mounting user certificates and keys #125

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Implement mounting user certificates and keys #125

merged 13 commits into from
Apr 11, 2024

Conversation

Kirill-Garbar
Copy link
Collaborator

@Kirill-Garbar Kirill-Garbar commented Apr 6, 2024 •
edited
Loading

This PR allows to define user-managed peer, client-server certificates.
It implements security specification:

spec:
...
  security:
    tls:
      peerTrustedCASecret: ca-peer-secret
      peerSecret: peer-secret
      serverSecret: server-secret
      clientTrustedCASecret: ca-client-secret
      clientSecret: client-secret
...

Enabled RBAC and root certificate watching is not part of this PR.

@Kirill-Garbar Kirill-Garbar marked this pull request as ready for review April 6, 2024 23:00
@sircthulhu sircthulhu added the feature New feature or request label Apr 9, 2024
@sircthulhu
Copy link
Member

This PR relates to #76

lllamnyp
lllamnyp reviewed Apr 9, 2024
View reviewed changes
api/v1alpha1/etcdcluster_types.go Show resolved Hide resolved
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
lllamnyp
lllamnyp reviewed Apr 9, 2024
View reviewed changes
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
@Kirill-Garbar Kirill-Garbar marked this pull request as draft April 9, 2024 20:31
@sergeyshevch sergeyshevch self-requested a review April 10, 2024 07:45
@kvaps kvaps mentioned this pull request Apr 10, 2024
Closed
1 task
@Kirill-Garbar Kirill-Garbar marked this pull request as ready for review April 10, 2024 21:33
@Kirill-Garbar Kirill-Garbar merged commit 765d551 into main Apr 11, 2024
5 checks passed
@Kirill-Garbar Kirill-Garbar deleted the feature/auth-v0 branch April 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lllamnyp lllamnyp lllamnyp left review comments

@sircthulhu sircthulhu sircthulhu approved these changes

@kvaps kvaps kvaps approved these changes

@hiddenmarten hiddenmarten Awaiting requested review from hiddenmarten hiddenmarten is a code owner

@AlexGluck AlexGluck Awaiting requested review from AlexGluck AlexGluck is a code owner

@sergeyshevch sergeyshevch Awaiting requested review from sergeyshevch sergeyshevch is a code owner

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kirill-Garbar @sircthulhu @kvaps @sergeyshevch @lllamnyp