add logging #179
Merged
add logging #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxxenix
requested review from
sircthulhu,
Kirill-Garbar and
sergeyshevch
as code owners
gecube
approved these changes
Apr 17, 2024
kvaps
reviewed
Apr 17, 2024
oxxenix
force-pushed
the
logging
branch
2 times, most recently
from
069e98a
to
720b5be
Compare
kvaps
approved these changes
Apr 17, 2024
|
Can we please check that all logs related to factories contains kind:EtcdCluster name/namespace? |
As I understood it was not implemented yet @oxxenix ? |
We're getting logger from request context which, afaik, already contain this info. And reconcileId as well. |
sergeyshevch
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #177