Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging enhancement #246

Merged
merged 3 commits into from
Jul 3, 2024
Merged

logging enhancement #246

merged 3 commits into from
Jul 3, 2024

Conversation

aobort
Copy link
Collaborator

@aobort aobort commented Jun 30, 2024 •
edited
Loading

Added:

  • stacktrace to log entry
  • cmd flag to enable/disable stacktrace (by default stacktrace enabled, stacktrace log level = error)

To disable stacktrace in logs, one should explicitly provide --enable-stacktrace=false flag or set corresponding env var (ENABLE_STACKTRACE=false).

Fixed:

  • fallback to default logger, if context does not contain logger
  • sensitive data in logged tls v1.Secret is now omitted

Fixes: #235

@aobort
handle context without logger
60da003 
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
@aobort
custom handler and cmd flag to enable stacktrace
169a212 
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
@github-actions github-actions bot added controllers enhancement New feature or request labels Jun 30, 2024
@aobort aobort changed the title log stacktrace logging enhancement Jun 30, 2024
@aobort
omit tls data from logged v1.Secrets
ece0b5d 
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
@aobort aobort marked this pull request as ready for review June 30, 2024 17:04
sircthulhu
sircthulhu approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kvaps kvaps requested a review from lllamnyp July 2, 2024 14:07
@kvaps kvaps merged commit d306349 into aenix-io:main Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sircthulhu sircthulhu sircthulhu approved these changes

@kvaps kvaps kvaps approved these changes

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar Kirill-Garbar is a code owner

@sergeyshevch sergeyshevch Awaiting requested review from sergeyshevch sergeyshevch is a code owner

@lllamnyp lllamnyp Awaiting requested review from lllamnyp

Assignees
No one assigned
Labels
controllers enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix logging system issues
3 participants
@aobort @sircthulhu @kvaps