Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dockerfile #5

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Improve Dockerfile #5

merged 3 commits into from
Mar 13, 2024

Conversation

AlexGluck
Copy link
Collaborator

  1. Union argument layers and copy source code.
  2. Changed layers order final image for grow cache hit

@AlexGluck
Improve Dockerfile
6351769 
1. Union argument layers and copy source code.
2. Changed layers order final image for grow cache hit
sircthulhu
sircthulhu reviewed Mar 10, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@AlexGluck AlexGluck marked this pull request as ready for review March 10, 2024 23:52
@AlexGluck AlexGluck enabled auto-merge (squash) March 10, 2024 23:52
sircthulhu
sircthulhu requested changes Mar 11, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@sircthulhu
Copy link
Member

Please, rebase branch on top of main branch for api/ and internal/controller directories to appear, so that build won't fail on not found error

sircthulhu
sircthulhu approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

apten-fors
apten-fors approved these changes Mar 13, 2024
View reviewed changes
Copy link

@apten-fors apten-fors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexGluck AlexGluck merged commit c77d9c6 into main Mar 13, 2024
@AlexGluck AlexGluck deleted the dockerfile branch March 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyshevch sergeyshevch sergeyshevch left review comments

@sircthulhu sircthulhu sircthulhu approved these changes

@apten-fors apten-fors apten-fors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlexGluck @sircthulhu @sergeyshevch @apten-fors @hiddenmarten