Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation minimum and change type to int32 for compatibility #57

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

sircthulhu
Copy link
Member

@sircthulhu sircthulhu commented Mar 20, 2024

  • Replicas field type changed to *int32 according to k8s api guidelines
  • remove unnecessary validation (everything is validated using OpenAPI scheme)
  • allow creation of cluster with 0 replicas

fixes #51

@sircthulhu sircthulhu force-pushed the feature/51-defaulting-webhook branch from a3a57cd to a8d9ae9 Compare March 20, 2024 11:46
@sircthulhu sircthulhu marked this pull request as draft March 20, 2024 12:47
@sircthulhu sircthulhu marked this pull request as ready for review March 20, 2024 13:24
api/v1alpha1/etcdcluster_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/etcdcluster_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/etcdcluster_webhook_test.go Outdated Show resolved Hide resolved
@sircthulhu sircthulhu enabled auto-merge (squash) March 20, 2024 16:23
@sircthulhu sircthulhu merged commit 2e25f81 into main Mar 21, 2024
3 checks passed
@sircthulhu sircthulhu deleted the feature/51-defaulting-webhook branch March 21, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move defaulting from webhooks to CRD
4 participants