Pre-commit via make #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddenmarten
force-pushed
the
pre-commit-init
branch
3 times, most recently
from
90d8cd4
to
bc724c7
Compare
|
As a result, it will look like: |
sircthulhu
requested changes
Mar 11, 2024
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.22.1 |
There was a problem hiding this comment.
We have version 1.21 in Dockerfile
kvaps
reviewed
Mar 13, 2024
Comment on lines
-76
to
+77
| _, err = utils.Run(cmd) | ||
| // TODO: Handle CRD installation error | ||
| _, _ = utils.Run(cmd) |
There was a problem hiding this comment.
Is it still makes sense after #15 get merged?
There was a problem hiding this comment.
Yep, it's a linter validation issue.
README.md
Outdated
Comment on lines
4
to
6
| ## Contributing | ||
| ### Prerequisites | ||
| - [pre-commit](https://pre-commit.com/#installation) |
hiddenmarten
force-pushed
the
pre-commit-init
branch
from
976e305
to
54bfa1d
Compare
gaalw
approved these changes
Mar 14, 2024
gecube
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.