Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[50] Helm-chart initial commit #78

Merged
merged 21 commits into from
Apr 3, 2024
Merged

[50] Helm-chart initial commit #78

merged 21 commits into from
Apr 3, 2024

Conversation

hiddenmarten
Copy link
Member

No description provided.

@hiddenmarten hiddenmarten mentioned this pull request Mar 23, 2024
Closed
kvaps
kvaps reviewed Mar 27, 2024
View reviewed changes
helm/etcd-operator/Chart.yaml Outdated Show resolved Hide resolved
helm/etcd-operator/values.yaml Outdated Show resolved Hide resolved
@hiddenmarten hiddenmarten changed the title [50] Put CRD with helm-hook annotations to the chart [50] Draft for helm-chart Mar 30, 2024
@hiddenmarten hiddenmarten requested a review from kvaps March 31, 2024 19:40
@hiddenmarten hiddenmarten marked this pull request as ready for review March 31, 2024 19:40
@hiddenmarten hiddenmarten changed the title [50] Draft for helm-chart [50] Helm-chart Mar 31, 2024
@hiddenmarten hiddenmarten changed the title [50] Helm-chart [50] Helm-chart initial commit Mar 31, 2024
@hiddenmarten hiddenmarten added the feature New feature or request label Apr 1, 2024
sircthulhu
sircthulhu previously requested changes Apr 1, 2024
View reviewed changes
.github/workflows/helm-publish.yaml Show resolved Hide resolved
charts/etcd-operator/README.md Outdated Show resolved Hide resolved
charts/etcd-operator/templates/cert-manager/certificate.yml Outdated Show resolved Hide resolved
charts/etcd-operator/templates/workload/deployment.yml Outdated Show resolved Hide resolved
charts/etcd-operator/values.yaml Outdated Show resolved Hide resolved
charts/etcd-operator/values.yaml Show resolved Hide resolved
charts/etcd-operator/values.yaml Outdated Show resolved Hide resolved
@hiddenmarten hiddenmarten dismissed sircthulhu’s stale review April 1, 2024 13:04

Changes were implemented

sircthulhu
sircthulhu approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiddenmarten hiddenmarten enabled auto-merge (squash) April 2, 2024 12:51
@kvaps kvaps self-assigned this Apr 2, 2024
kvaps
kvaps approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@kvaps
Copy link
Member

kvaps commented Apr 3, 2024

Just simple note, I got the following warning when installing on Talos Linux:

W0403 12:57:17.819266   16965 warnings.go:70] would violate PodSecurity "restricted:latest": runAsNonRoot != true (pod or containers "etcd-operator", "kube-rbac-proxy" must set securityContext.runAsNonRoot=true), seccompProfile (pod or containers "etcd-operator", "kube-rbac-proxy" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

@hiddenmarten hiddenmarten merged commit 1c851a6 into main Apr 3, 2024
5 checks passed
@hiddenmarten hiddenmarten deleted the feature/50-helm-chart branch April 3, 2024 11:11
@hiddenmarten hiddenmarten linked an issue Apr 3, 2024 that may be closed by this pull request
Helm chart #50
Closed
@hiddenmarten hiddenmarten mentioned this pull request Apr 3, 2024
Open
@hiddenmarten hiddenmarten self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sircthulhu sircthulhu sircthulhu approved these changes

@kvaps kvaps kvaps approved these changes

@AlexGluck AlexGluck Awaiting requested review from AlexGluck AlexGluck is a code owner

@sergeyshevch sergeyshevch Awaiting requested review from sergeyshevch

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar

Assignees

@kvaps kvaps

@hiddenmarten hiddenmarten

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart
3 participants
@hiddenmarten @kvaps @sircthulhu