Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/customize probe settings in pod spec #97

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Feature/customize probe settings in pod spec #97

merged 12 commits into from
Apr 3, 2024

Conversation

ilya-hontarau
Copy link
Contributor

@ilya-hontarau ilya-hontarau commented Mar 29, 2024 •
edited by sergeyshevch
Loading

Closes #82

sircthulhu
sircthulhu requested changes Mar 29, 2024
View reviewed changes
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset_test.go Outdated Show resolved Hide resolved
api/v1alpha1/etcdcluster_types.go Show resolved Hide resolved
@sircthulhu sircthulhu added the feature New feature or request label Mar 29, 2024
@sircthulhu sircthulhu added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 31, 2024
sergeyshevch
sergeyshevch requested changes Apr 1, 2024
View reviewed changes
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset_test.go Show resolved Hide resolved
sircthulhu
sircthulhu approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sergeyshevch
sergeyshevch requested changes Apr 2, 2024
View reviewed changes
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
@kvaps kvaps requested a review from sergeyshevch April 2, 2024 14:30
@sircthulhu sircthulhu merged commit ebee713 into aenix-io:main Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sircthulhu sircthulhu sircthulhu approved these changes

@sergeyshevch sergeyshevch sergeyshevch approved these changes

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar Kirill-Garbar is a code owner

Assignees
No one assigned
Labels
feature New feature or request ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to customize probe settings in podSpec
3 participants
@ilya-hontarau @sircthulhu @sergeyshevch