Merge pull request #86 from mtaylor/fix_connection_error

Fix connection error

app/exceptions/tim/exceptions.rb

@@ -0,0 +1,6 @@
+module Tim
+  module Error
+    class ImagefactoryConnectionRefused < ::StandardError
+    end
+  end
+end

app/models/tim/provider_image.rb

@@ -47,6 +47,9 @@ def create_factory_provider_image
         provider_image.save!
         populate_factory_fields(provider_image)
         self.save
+      rescue Errno::ECONNREFUSED
+        raise Tim::Error::ImagefactoryConnectionRefused.new("Unable to connect"\
+         " to Imagefactory server @ #{Tim::ImageFactory::Base.site}")
       rescue => e
         # TODO Add proper error handling
         raise e

app/models/tim/target_image.rb

@@ -50,6 +50,9 @@ def create_factory_target_image
 
         populate_factory_fields(target_image)
         self.save
+      rescue Errno::ECONNREFUSED
+        raise Tim::Error::ImagefactoryConnectionRefused.new("Unable to connect"\
+         " to Imagefactory server @ #{Tim::ImageFactory::Base.site}")
       rescue => e
         # TODO Add proper error handling
         raise e

lib/tim/engine.rb

@@ -16,6 +16,11 @@ class Engine < Rails::Engine
       Dir[Tim::Engine.root.join('app', 'patches', '**', '*.rb')].each do |p|
         require p
       end
+
+      # Load Exceptions
+      Dir[Tim::Engine.root.join('app', 'exceptions', '**', '*.rb')].each do |e|
+        require e
+      end
     end
   end
 end

spec/models/provider_image_spec.rb

@@ -77,6 +77,15 @@ module Tim
           ti.should_not_receive(:create_factory_provider_image)
           ti.save
         end
+
+        it "should raise ImagefactoryConnectionRefused exception when it can"\
+          " not connect to Imagefactory" do
+          expect {
+            Tim::ImageFactory::ProviderImage.stub(:new).and_raise(Errno::ECONNREFUSED)
+            provider_image = FactoryGirl.build(:provider_image_with_full_tree)
+            provider_image.send(:create_factory_provider_image)
+          }.to raise_error(Tim::Error::ImagefactoryConnectionRefused)
+        end
       end
     end
   end

spec/models/target_image_spec.rb

@@ -112,6 +112,15 @@ module Tim
           mock_target_image.should_receive(:save!)
           target_image.save
         end
+
+        it "should raise ImagefactoryConnectionRefused exception when it can"\
+          " not connect to Imagefactory" do
+          expect {
+            Tim::ImageFactory::TargetImage.stub(:new).and_raise(Errno::ECONNREFUSED)
+            target_image = TargetImage.new
+            target_image.send(:create_factory_target_image)
+          }.to raise_error(Tim::Error::ImagefactoryConnectionRefused)
+        end
       end
     end
   end