Don't erase %{app_root} during %pre #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's roughly what is happening here
- RPM is asked to update aeolus-conductor
- As part of the transaction, RPM checks the status of settings.yml.
RPM finds that (1) settings.yml is marked as %config in the spec
file, (2) settings.yml as shipped with $new_version contains the
same content as shipped with $old_version (it ignores the contents
of the file as it exists on the filesystem), and (3) settings.yml
has local modifications (via aeolus-configure).
- Because of 1-3 above, RPM marks settings.yml to be skipped during
the transaction.
- The %pre scriptlet runs, and removes %{app_root}, which in turn
removes settings.yml.
- Because the transaction has already decided to skip settings.yml, no
action is taken on it. At this point, the file is gone. RPM will
not lay down the file as it exists in the RPM, nor will it produce
any sort of .rpmsave or .rpmnew file.
Related bug:
860822 - aeolus-conductor RPM upgrade deletes settings.yml
https://bugzilla.redhat.com/show_bug.cgi?id=860822
|
ACK - works for me |
sseago
added a commit
that referenced
this pull request
Oct 2, 2012
Don't erase %{app_root} during %pre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's roughly what is happening here
RPM finds that (1) settings.yml is marked as %config in the spec
file, (2) settings.yml as shipped with $new_version contains the
same content as shipped with $old_version (it ignores the contents
of the file as it exists on the filesystem), and (3) settings.yml
has local modifications (via aeolus-configure).
the transaction.
removes settings.yml.
action is taken on it. At this point, the file is gone. RPM will
not lay down the file as it exists in the RPM, nor will it produce
any sort of .rpmsave or .rpmnew file.
Related bug:
860822 - aeolus-conductor RPM upgrade deletes settings.yml
https://bugzilla.redhat.com/show_bug.cgi?id=860822