Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Deprecate the alignment module #46

Closed
TonyBagnall opened this issue Feb 8, 2023 · 1 comment
Closed

[ENH] Deprecate the alignment module #46

TonyBagnall opened this issue Feb 8, 2023 · 1 comment
Assignees
@TonyBagnall
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Feb 8, 2023 •
edited
Loading

The alignment module wraps a package called dtw-python which contains an implementation of dtw that is slower than our ours. The functionality of alignment is available in distances using our own distance functions. The only place it is used is in KNN, which I would like to remove
#47
#39
and dists_kernels, which I would also like to deprecate. @chrisholder
@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement distances Distances package labels Feb 8, 2023
@TonyBagnall TonyBagnall mentioned this issue Feb 8, 2023
Closed
@MatthewMiddlehurst
Copy link
Member

Use #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TonyBagnall TonyBagnall

Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisholder @TonyBagnall @MatthewMiddlehurst