Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Remove dists_kernels #47

Closed
TonyBagnall opened this issue Feb 8, 2023 · 0 comments · Fixed by #179
Closed

[ENH] Remove dists_kernels #47

TonyBagnall opened this issue Feb 8, 2023 · 0 comments · Fixed by #179
Assignees
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Feb 8, 2023

we currently have a module distances, which contains elastic distance functions, and one called dists_kernels that wraps everything in objects. I would like to remove dists_kernels. It is confusing having both, and I see no benefit from wrapping distances and introducing things like PwTrafoPanelPipeline, BasePairwiseTransformerPanel etc

I think this description would make little sense to most people.
https://www.sktime.org/en/stable/api_reference/dists_kernels.html

conceptually, insisting that functions be wrapped in objects (functor pattern) is much more Java like than python. Even java recognises functors are a clumsy pattern and introduced lambdas. To go the other way with python just seems perverse. @chrisholder can comment, but I believe all other relevant packages treat distances as functions.

#39
#46
https://arxiv.org/abs/2205.15181

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement distances Distances package labels Feb 8, 2023
@TonyBagnall TonyBagnall self-assigned this Feb 8, 2023
@TonyBagnall TonyBagnall changed the title [ENH] deprecate dists_kernels [ENH] Remove dists_kernels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant