New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT, BUG] Modify njit func generator to support python functions #1044
[MNT, BUG] Modify njit func generator to support python functions #1044
Conversation
Thank you for contributing to
|
I've added the full pytest tag so it will run all the tests, not actually sure if setting this and/or codecov then runs without njit, @MatthewMiddlehurst? |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tags added should be fine. Good work, This should fix the periodic tests and I think #1043 should make the future ones a lot more stable.
Reference Issues/PRs
Fixes #1020
What does this implement/fix? Explain your changes.
Modify
generate_new_default_njit_func
function to support python function and be coherent when DISABLE_JIT option is set toTrue
, so it returns a python function.Does your contribution introduce a new dependency? If yes, which one?
No.
For all contributions
For developers with write access