Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT, BUG] Modify njit func generator to support python functions #1044

Merged

Conversation

baraline
Copy link
Contributor

Reference Issues/PRs

Fixes #1020

What does this implement/fix? Explain your changes.

Modify generate_new_default_njit_func function to support python function and be coherent when DISABLE_JIT option is set to True, so it returns a python function.

Does your contribution introduce a new dependency? If yes, which one?

No.

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For developers with write access
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@baraline baraline added the codecov actions Run the codecov action on a PR label Jan 13, 2024
@baraline baraline linked an issue Jan 13, 2024 that may be closed by this pull request
@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working maintenance Continuous integration, unit testing & package distribution labels Jan 13, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$, $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall added the full pytest actions Run the full pytest suite on a PR label Jan 13, 2024
@TonyBagnall
Copy link
Contributor

TonyBagnall commented Jan 13, 2024

I've added the full pytest tag so it will run all the tests, not actually sure if setting this and/or codecov then runs without njit, @MatthewMiddlehurst?

@baraline baraline marked this pull request as ready for review January 13, 2024 23:18
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags added should be fine. Good work, This should fix the periodic tests and I think #1043 should make the future ones a lot more stable.

@baraline baraline merged commit 211d714 into main Jan 15, 2024
20 checks passed
@baraline baraline deleted the 1020-bug-similarity-search-tests-failing-without-numba-enabled branch January 15, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codecov actions Run the codecov action on a PR full pytest actions Run the full pytest suite on a PR maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Similarity search tests failing without numba enabled
3 participants