Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] make metric precomputed in distances sklearn tests #1193

Merged
merged 3 commits into from Feb 29, 2024
Merged

Conversation

TonyBagnall
Copy link
Contributor

Reference Issues/PRs

See #1189 (fixes it I think, @MatthewMiddlehurst)

Sets kernel to precomputed in SVM distance test for pairwise.

@TonyBagnall TonyBagnall added testing Testing related issue or pull request distances Distances package labels Feb 17, 2024
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label Feb 17, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@MatthewMiddlehurst
Copy link
Member

I think the KNN test also has the same issue.

It would be good to test predict with a different dataset and n_cases IMO.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@TonyBagnall
Copy link
Contributor Author

I think the KNN test also has the same issue.

It would be good to test predict with a different dataset and n_cases IMO.

changed them round, take a look

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TonyBagnall TonyBagnall merged commit d6311bf into main Feb 29, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/svm branch February 29, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distances Distances package testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants