Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Update similarity search with new base classes #1310

Closed

Conversation

baraline
Copy link
Contributor

@baraline baraline commented Mar 13, 2024

Reference Issues/PRs

Fixes #1243.

What does this implement/fix? Explain your changes.

  • Remake similarity search module to use Series and Collection base classes
  • Add "fastest" option for distance speedup selection
  • Rename "ConvolveDotProduct" speedup to "Mueen" for Euclidean distance.

Remaining TODOs:

  • Make a SimilaritySearchBroadcaster to use BaseSeriesSimialritySearch with collections
  • Check Docstrings have been correctly updated
  • Update documentation and example notebooks

@baraline baraline added API design API design & software architecture maintenance Continuous integration, unit testing & package distribution similarity search Similarity search package labels Mar 13, 2024
@baraline baraline self-assigned this Mar 13, 2024
@baraline baraline linked an issue Mar 13, 2024 that may be closed by this pull request
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#006b75}{\textsf{similarity search}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@baraline baraline closed this Apr 11, 2024
@baraline baraline deleted the 1243-mnt-update-similarity-search-with-new-base-classes branch April 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design API design & software architecture maintenance Continuous integration, unit testing & package distribution similarity search Similarity search package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT] Update similarity search with new base classes
1 participant