Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Loading ability in deep learning modules for classification/regression/clustering #1374

Merged
merged 13 commits into from
May 25, 2024

Conversation

hadifawaz1999
Copy link
Contributor

@hadifawaz1999 hadifawaz1999 commented Apr 6, 2024

Fix #385

Deep learning base models now have a loading function to load a saved pretrained model and skip the fitting phase. This required testing the functionality in deep base, which i added.

I added a demo on how to use this functionality in the deep learning notebook examples/networks/deep_learning
I also updated some of the figures, using the new ones from here now: https://msd-irimas.github.io/pages/dl4tsc/

@hadifawaz1999 hadifawaz1999 added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package clustering Clustering package regression Regression package deep learning Deep learning related examples Example notebook related labels Apr 6, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should create a temp directory to the writing and loading of files, and possibly only do it on overnight tests (although not sure about that)

this from test_data_writers.py

with tempfile.TemporaryDirectory() as tmp:
    write_to_tsfile(X=X, path=tmp, y=y, problem_name=problem_name)
    load_path = os.path.join(tmp, problem_name)
    newX, newy = load_from_tsfile(full_file_path_and_name=load_path)

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hadifawaz1999 hadifawaz1999 merged commit 6695dc0 into main May 25, 2024
14 checks passed
@hadifawaz1999 hadifawaz1999 deleted the aif/dl-loading branch May 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package clustering Clustering package deep learning Deep learning related enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Detail the saving and loading deep learning models
2 participants