-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Remove optional from docstrings #1458
Conversation
* find `optional \(default=(.*)\)`, replace with `default=$1` * review all changes
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, thanks, I probably would have ended up doing it manually :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, had a quick scan and didnt see anything off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
Reference Issues/PRs
Fixes #1451
What does this implement/fix? Explain your changes.
Find
optional \(default=(.*)\)
, replace withdefault=$1
.Does your contribution introduce a new dependency? If yes, which one?
None
PR checklist
For all contributions