Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implement Proximity Tree classifier using aeon distances #1566

Merged
merged 40 commits into from
Jun 27, 2024

Conversation

itsdivya1309
Copy link
Contributor

@itsdivya1309 itsdivya1309 commented May 24, 2024

Related to: #159

We implemented the ProximityTree class using aeon distances.
This will be used to create the Proximity Forest class.

  • Coded the ProximityTree class
  • Wrapped Gini functions with Numba
  • Wrote unit tests
  • Added the class to docs/api_reference

@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement labels May 24, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall
Copy link
Contributor

this is good. From our end @MatthewMiddlehurst we should set up a pipeline for running experiments to check equivalence to the Java results, as that was the heart of the problem last time. No rush of course, project has not started yet :)

@itsdivya1309 itsdivya1309 changed the title [ENH] Implement Proximity Forest classifier using aeon.distances [ENH] Implement Proximity Tree classifier using aeon distances Jun 14, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the codecov actions Run the codecov action on a PR label Jun 14, 2024
@itsdivya1309
Copy link
Contributor Author

I have completed the framework for Proximity Tree along with it's API.

@itsdivya1309 itsdivya1309 marked this pull request as ready for review June 17, 2024 03:28
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on “surface” content, I'll have a proper look at the algorithmic correctness a bit later

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, left a few comments. We may revisit this later down the line if there are issues, but appears to be fine for now.

I would add this to the API documentation in docs/ in this PR.

There are some if statements here which are not covered by testing. Not going to block this PR because of them, but if you find the time and can figure out how to get to them reasonably it would be nice. https://app.codecov.io/gh/aeon-toolkit/aeon/pull/1566/blob/aeon/classification/distance_based/_proximity_tree.py

@MatthewMiddlehurst
Copy link
Member

Try merging the main branch for the pre-commit test, I will take a further look if it does not work after.

@itsdivya1309
Copy link
Contributor Author

Try merging the main branch for the pre-commit test, I will take a further look if it does not work after.

I have merged the main branch, but it is still failing.

TonyBagnall
TonyBagnall previously approved these changes Jun 21, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking changes from me, looks good

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@TonyBagnall TonyBagnall merged commit fd27e7f into aeon-toolkit:main Jun 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants