Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add AEBiGRUNetwork #1583

Merged
merged 14 commits into from
Jul 11, 2024
Merged

[ENH] Add AEBiGRUNetwork #1583

merged 14 commits into from
Jul 11, 2024

Conversation

aadya940
Copy link
Contributor

Implements Auto-Encoder based on BiDirectional GRU Network.

@aeon-actions-bot aeon-actions-bot bot added the networks Networks package label May 31, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@aadya940 aadya940 changed the title Add AEBiGRUNetwork [ENH] Add AEBiGRUNetwork May 31, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label May 31, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the codecov actions Run the codecov action on a PR label Jun 5, 2024
Copy link
Contributor

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to go, just need the test to assert the shapes of input and output of the network are the same

Copy link
Contributor

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aadya940
Copy link
Contributor Author

this is good to go, just need the test to assert the shapes of input and output of the network are the same

Already done in test_all_networks.py.

@MatthewMiddlehurst MatthewMiddlehurst merged commit 2eb88fd into aeon-toolkit:main Jul 11, 2024
16 checks passed
@aadya940
Copy link
Contributor Author

There's a mistake here.
_config.structure should be "auto-encoder" not "encoder".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement networks Networks package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants