Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Pandas 2.0.0 deprecation actions (part 2) #189

Merged
merged 20 commits into from Mar 18, 2023
Merged

[MNT] Pandas 2.0.0 deprecation actions (part 2) #189

merged 20 commits into from Mar 18, 2023

Conversation

aiwalter
Copy link
Contributor

succesor PR of #153

issue: #150

@aiwalter
Copy link
Contributor Author

@MatthewMiddlehurst could you pls have a look at this test? aeon/transformations/panel/tests/test_interpolate.py::test_resizing, its failing for pandas==2.0.0rc0.

@MatthewMiddlehurst
Copy link
Member

I can probably have a look at it at some point if needed, but I have not ever touched those tests or the transformer.

@aiwalter
Copy link
Contributor Author

@MatthewMiddlehurst I think its passing now, might have been a random failure

@aiwalter aiwalter marked this pull request as ready for review March 14, 2023 14:49
@aiwalter aiwalter added forecasting Forecasting package maintenance Continuous integration, unit testing & package distribution labels Mar 14, 2023
@aiwalter
Copy link
Contributor Author

@MatthewMiddlehurst ok the test aeon/transformations/panel/tests/test_interpolate.py::test_resizing seems actually to fail with pandas==2.0.0rc0

GuzalBulatova
GuzalBulatova approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @aiwalter !

@aiwalter aiwalter merged commit e4701b7 into aeon-toolkit:main Mar 18, 2023
13 checks passed
@aiwalter aiwalter mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuzalBulatova GuzalBulatova GuzalBulatova approved these changes

@MatthewMiddlehurst MatthewMiddlehurst Awaiting requested review from MatthewMiddlehurst MatthewMiddlehurst is a code owner

@lmmentel lmmentel Awaiting requested review from lmmentel

@ltsaprounis ltsaprounis Awaiting requested review from ltsaprounis ltsaprounis is a code owner

Assignees
No one assigned
Labels
forecasting Forecasting package maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aiwalter @MatthewMiddlehurst @GuzalBulatova