Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] added missing dl tag to inceptionTime classifier #203

Merged

Conversation

hadifawaz1999
Copy link
Contributor

@hadifawaz1999 hadifawaz1999 commented Mar 17, 2023

Reference Issues/PRs

Fixes #193

What does this implement/fix? Explain your changes.

Added the deep learning algorithm name tag to inceptionTime classifier given that he inherits from BaseClassifier and not BaseDeepClassifier

Does your contribution introduce a new dependency? If yes, which one?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@hadifawaz1999 hadifawaz1999 requested review from TonyBagnall and removed request for aiwalter and GuzalBulatova March 17, 2023 19:38
@TonyBagnall TonyBagnall merged commit 3918d73 into aeon-toolkit:main Mar 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing tag in InceptionTime
2 participants