Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Fix pytest by setting upper bound on dash #206

Merged
merged 1 commit into from Mar 17, 2023
Merged

[MNT] Fix pytest by setting upper bound on dash #206

merged 1 commit into from Mar 17, 2023

Conversation

MatthewMiddlehurst
Copy link
Member

The issue is fixed in plotly/dash#2461, but a new release is required to fix our CI.

@MatthewMiddlehurst MatthewMiddlehurst added the maintenance Continuous integration, unit testing & package distribution label Mar 17, 2023
ltsaprounis
ltsaprounis approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@ltsaprounis ltsaprounis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MatthewMiddlehurst
Copy link
Member Author

tests no longer seem to be crashing 10 minutes in like other PRs, I will merge this now and revert if any issues arise. The change is minor.

@MatthewMiddlehurst MatthewMiddlehurst merged commit 5f2dec4 into main Mar 17, 2023
13 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the test_fix branch March 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltsaprounis ltsaprounis ltsaprounis approved these changes

@aiwalter aiwalter Awaiting requested review from aiwalter

@GuzalBulatova GuzalBulatova Awaiting requested review from GuzalBulatova

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatthewMiddlehurst @ltsaprounis