New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adapt rocket classifiers to return numpy arrays instead of data frames #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyBagnall
changed the title
Ajb/rocket
[ENH] Adapt rocket classifiers to return numpy arrays not pandas
Mar 17, 2023
TonyBagnall
changed the title
[ENH] Adapt rocket classifiers to return numpy arrays not pandas
[ENH] Adapt rocket classifiers to return numpy arrays instead of data frames
Mar 17, 2023
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MatthewMiddlehurst
previously requested changes
Mar 27, 2023
MatthewMiddlehurst
approved these changes
Apr 5, 2023
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, all rocket transforms are converted into pandas before return in transform, despite all operations being performed on numpy. This PR switches all the rocket variants to return numpy arrays in transform. The classifiers that use these transforms then just convert it back to numpy. It is much more natural to just not use pandas at all. There are two stages
This PR is part of #208. Note I have left the unequal length version for now. For a bonus 10 pts, I will also
I have reverted the MultiRocket because the base class conversions are breaking it with 2D numpy. It breaks them all, but it makes MultiRocket fail tests. We can wait to do this until after we have resolved the conversion problem.