Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix Imputer bugs #24

Merged
merged 7 commits into from Feb 20, 2023
Merged

[BUG] Fix Imputer bugs #24

merged 7 commits into from Feb 20, 2023

Conversation

aiwalter
Copy link
Contributor

@aiwalter aiwalter commented Feb 5, 2023

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Set value default to 0. This allows to better do grid search over the methods without breaking for value=None
  • In case a whole column contains only NaN (which can likely happen also in cross-validation) either in fit or transform data, the column is filled with value

@aiwalter aiwalter added bug Something isn't working transformations Transformations package labels Feb 5, 2023
@aiwalter aiwalter requested review from ltsaprounis and lmmentel and removed request for ltsaprounis February 6, 2023 15:42
patrickzib
patrickzib reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

sktime/transformations/series/impute.py Outdated Show resolved Hide resolved
@lmmentel lmmentel self-requested a review February 6, 2023 16:31
lmmentel
lmmentel previously approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@lmmentel lmmentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrickzib
patrickzib reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "Method to fill the missing values values."

@aiwalter
Copy link
Contributor Author

aiwalter commented Feb 6, 2023

lets wait for CI/CD to run before merging

@MatthewMiddlehurst MatthewMiddlehurst added bugfix bug Something isn't working and removed bug Something isn't working bugfix labels Feb 7, 2023
@lmmentel lmmentel merged commit e1e3b75 into main Feb 20, 2023
@lmmentel lmmentel deleted the mw/imputer branch February 20, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmmentel lmmentel lmmentel approved these changes

@patrickzib patrickzib Awaiting requested review from patrickzib

@MatthewMiddlehurst MatthewMiddlehurst Awaiting requested review from MatthewMiddlehurst

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall

@GuzalBulatova GuzalBulatova Awaiting requested review from GuzalBulatova

Assignees
No one assigned
Labels
bug Something isn't working transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aiwalter @patrickzib @lmmentel @MatthewMiddlehurst