Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update erp distance #333

Merged
merged 168 commits into from May 4, 2023
Merged

[ENH] Update erp distance #333

merged 168 commits into from May 4, 2023

Conversation

chrisholder
Copy link
Contributor

@chrisholder chrisholder commented Apr 25, 2023

Reference Issues/PRs

This pr depends on pr #332

What does this implement/fix? Explain your changes.

This pr updates erp to the new format for distances. In addition in doing so it makes optimisations for computing the distances between multiple time series.

In addition, this pr updates the 'g' parameter allowing a array to be passed that allows for a different value of g per channel (the suggested way in the original paper to set g is the standard deviation of each channel for each channel).

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
  • For new estimators, I've added the estimator to the online documentation.

@chrisholder chrisholder marked this pull request as ready for review May 2, 2023 15:50
@chrisholder chrisholder mentioned this pull request May 2, 2023
4 tasks
@chrisholder chrisholder merged commit cb5ac17 into main May 4, 2023
16 checks passed
@chrisholder chrisholder deleted the update-erp-distance branch May 4, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants