Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Fix workflow concurrency #350

Merged
merged 6 commits into from Apr 28, 2023
Merged

[MNT] Fix workflow concurrency #350

merged 6 commits into from Apr 28, 2023

Conversation

MatthewMiddlehurst
Copy link
Member

#339 did not cancel the previous run on main when a new PR was merged. This attempts to fix that.

@MatthewMiddlehurst MatthewMiddlehurst added the maintenance Continuous integration, unit testing & package distribution label Apr 28, 2023
@MatthewMiddlehurst
Copy link
Member Author

This does work for PRs at least, I read up a little bit more and I imagine ${{ github.workflow }}-${{ github.run_id }} is always going to be unique. ${{ github.workflow }}-${{ github.ref }} should cancel all runs for this workflow on the same branch, which is what we want I'm pretty sure if ${{ github.workflow }}-${{ github.head_ref }} fails.

@TonyBagnall TonyBagnall merged commit 2f83928 into main Apr 28, 2023
16 checks passed
@TonyBagnall TonyBagnall deleted the test_workflow branch April 28, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmmentel lmmentel lmmentel approved these changes

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MatthewMiddlehurst @lmmentel @TonyBagnall