New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add model checkpoint to inceptionTime deep classifier #362
[ENH] add model checkpoint to inceptionTime deep classifier #362
Conversation
This should be ready now to get in. |
Have you removed it from excluded list? |
@TonyBagnall which test do we exclude, the |
…nd inception classifiers
@TonyBagnall @MatthewMiddlehurst it ended up generating the same long int :) and so I went back the older naming technique, hoping that this technique has more randomness in it |
…model_checkpoint_Deep_classifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably import time
at the top of the file but I'm not gonna make this rerun CI for that.
Yeah @MatthewMiddlehurst i can keep it in mind for the next PR that includes deep learning models |
Part of #321
to see if it works fine, if yes than I should add the removal of the file saved.
Even if the tests get checked, this should get in before the addition of the removal of the saved model using
os.remove