Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add model checkpoint to inceptionTime deep classifier #362

Merged
merged 14 commits into from May 4, 2023

Conversation

hadifawaz1999
Copy link
Contributor

Part of #321
to see if it works fine, if yes than I should add the removal of the file saved.
Even if the tests get checked, this should get in before the addition of the removal of the saved model using os.remove

@hadifawaz1999 hadifawaz1999 added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package deep learning Deep learning related labels May 1, 2023
@hadifawaz1999
Copy link
Contributor Author

This should be ready now to get in.

TonyBagnall
TonyBagnall previously approved these changes May 3, 2023
@TonyBagnall
Copy link
Contributor

Have you removed it from excluded list?

@hadifawaz1999
Copy link
Contributor Author

@TonyBagnall which test do we exclude, the test_save_estimators_to_file only or the test_persistence_via_pickle as well ?

@hadifawaz1999
Copy link
Contributor Author

@TonyBagnall @MatthewMiddlehurst it ended up generating the same long int :) and so I went back the older naming technique, hoping that this technique has more randomness in it

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably import time at the top of the file but I'm not gonna make this rerun CI for that.

@hadifawaz1999
Copy link
Contributor Author

Yeah @MatthewMiddlehurst i can keep it in mind for the next PR that includes deep learning models

@MatthewMiddlehurst MatthewMiddlehurst merged commit b2526ff into main May 4, 2023
16 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the add_model_checkpoint_Deep_classifiers branch May 4, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package deep learning Deep learning related enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants