Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] updated dba to support custom parameters #454

Merged
merged 15 commits into from May 27, 2023
Merged

[ENH] updated dba to support custom parameters #454

merged 15 commits into from May 27, 2023

Conversation

chrisholder
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

When the distance module was updated support for custom kwargs for the averaging method in kmeans was disabled. This PR updates kmeans to support custom averaging kwargs with the new distance module.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
  • For new estimators, I've added the estimator to the online documentation.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont want the experiments directory here really, it can go in tsml-eval

aeon/clustering/experiments/cluster_run.sh Outdated Show resolved Hide resolved
@TonyBagnall
Copy link
Contributor

TonyBagnall commented May 25, 2023

should the file still be called dba? Cant we use if for mba etc?

@TonyBagnall TonyBagnall merged commit 1a4c22a into main May 27, 2023
19 checks passed
@TonyBagnall TonyBagnall deleted the dba-fixes branch May 27, 2023 20:32
@MatthewMiddlehurst MatthewMiddlehurst added enhancement New feature, improvement request or other non-bug code enhancement distances Distances package labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants