Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force CI to use MacOS 11 #261

Closed
wants to merge 1 commit into from
Closed

Conversation

BigslimVdub
Copy link

Update MacOS CI to use Big Sur (11.6.2 currently) over Catalina. Currently, the macos-latest still uses 10.15 and binaries may not execute properly on BigSur which is required for future updates for Mac ARM integration of Aeon CLI. The timeline for the final integration of CI for Big Sur is unknown but this will force the use of Big Sur indefinitely until an update is needed for future OS.

Update MacOS CI to use Big Sur (11.6.2 currently) over Catalina. Currently, the macos-latest still uses 10.15 and binaries may not execute properly on BigSur which is required for future updates for Mac ARM integration of Aeon CLI. The timeline for the final integration of CI for Big Sur is unknown but this will force the use of Big Sur indefinitely until an update is needed for future OS.
@BigslimVdub
Copy link
Author

Please review

@stoffu
Copy link

stoffu commented Feb 2, 2022

I don't understand the purpose of this patch. Also, it seems applicable to Monero. Please send a PR there and get feedback.

@BigslimVdub
Copy link
Author

I don't understand the purpose of this patch. Also, it seems applicable to Monero. Please send a PR there and get feedback.

Github “macOS-latest” is tagged Catalina not Big Sur right now so if you leave this as is, binaries may not execute on some macs using Big Sur.

@iamsmooth
Copy link

That does seem applicable to Monero

@BigslimVdub BigslimVdub mentioned this pull request Feb 3, 2022
@stoffu
Copy link

stoffu commented Feb 25, 2022

As per the documentation https://github.com/actions/virtual-environments/#available-environments, macos-latest is the same as macos-11, so this patch effectively changes nothing.

@BigslimVdub
Copy link
Author

Github has updated to 11.6.4 now for macOS latest since opening this pr so it is now irrelevant. See os on ci build:
https://github.com/aeonix/aeon/runs/5328443669?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants