Allow fractional outputs to be ignored /monero#4071 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wallet/wallet2.cpp
Outdated
| @@ -7454,6 +7461,12 @@ std::vector<wallet2::pending_tx> wallet2::create_transactions_2(std::vector<cryp | |||
| for (size_t i = 0; i < m_transfers.size(); ++i) | |||
| { | |||
| const transfer_details& td = m_transfers[i]; | |||
| const uint64_t fractional_threshold = fee_multiplier * fee_per_kb/1024 * estimate_tx_size(use_rct, 1, fake_outs_count, -1, 0, bulletproof) / 10; | |||
There was a problem hiding this comment.
That formula seems wrong. It should probably use estimate_tx_size(outs)-estimate_tx_size(outs-1) or somhtng.
What's the 10 ?
There was a problem hiding this comment.
You're right, thanks.
The 10 is an arbitrary safety margin to place the threshold at 10% of the estimated size in case the estimate is an overestimation. I think it can be dropped. What do you think?
stoffu
force-pushed
the
aeon-ignore-fractional-outputs
branch
from
11a72a4
to
90a9bcd
Compare
stoffu
force-pushed
the
aeon-ignore-fractional-outputs
branch
from
90a9bcd
to
be297b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.