Skip to content

Commit

Permalink
refactory: move pkg and plugin to internal directory since they're no…
Browse files Browse the repository at this point in the history
…t public packages

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
  • Loading branch information
zhaohuabing committed Jul 29, 2023
1 parent eace397 commit 3a5033d
Show file tree
Hide file tree
Showing 78 changed files with 77 additions and 76 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Expand Up @@ -24,9 +24,9 @@ jobs:
with:
go-version: 1.19
- name: Build
run: go build -race ./...
run: go build -race ./internal/...
- name: Test
run: go test -race `go list ./... | grep -v e2e`
run: go test -race `go list ./internal/... | grep -v e2e`
go-lint:
name: go-lint
runs-on: ubuntu-latest
Expand All @@ -36,7 +36,7 @@ jobs:
- name: golint
uses: Jerome1337/golint-action@v1.0.2
with:
golint-path: './...'
golint-path: './internal/...'
- name: Setup Go
uses: actions/setup-go@v1
with:
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Expand Up @@ -56,7 +56,7 @@ uninstall-demo-brpc:
bash demo/uninstall-demo.sh brpc
test: style-check
$(GOMOD) tidy
$(GOTEST) -race `go list ./pkg/... ./plugin/... | grep -v e2e`
$(GOTEST) -race `go list ./internal/... | grep -v e2e`
build: test
CGO_ENABLED=0 GOOS=$(IMAGE_OS) GOARCH=$(IMAGE_ARCH) $(GOBUILD) -o $(OUT)/$(IMAGE_ARCH)/$(IMAGE_OS)/$(IMAGE_NAME) $(MAIN_PATH)
docker-build: build
Expand All @@ -72,10 +72,10 @@ cross_build_images:
clean:
rm -rf $(OUT)
style-check:
gofmt -l -d ./pkg ./plugin
goimports -l -d ./pkg ./plugin
gofmt -l -d ./internal
goimports -l -d ./internal
lint:
golint ./pkg/... ./plugin/...
golint ./internal/...
golangci-lint run --tests="false"
e2e-dubbo:
go test -v github.com/aeraki-mesh/aeraki/test/e2e/dubbo/...
Expand Down
16 changes: 8 additions & 8 deletions cmd/aeraki/main.go
Expand Up @@ -23,14 +23,14 @@ import (

"github.com/google/uuid"

"github.com/aeraki-mesh/aeraki/pkg/bootstrap"
"github.com/aeraki-mesh/aeraki/pkg/config/constants"
"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/plugin/kafka"
"github.com/aeraki-mesh/aeraki/plugin/metaprotocol"
"github.com/aeraki-mesh/aeraki/plugin/thrift"
"github.com/aeraki-mesh/aeraki/plugin/zookeeper"
"github.com/aeraki-mesh/aeraki/internal/bootstrap"
"github.com/aeraki-mesh/aeraki/internal/config/constants"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/plugin/kafka"
"github.com/aeraki-mesh/aeraki/internal/plugin/metaprotocol"
"github.com/aeraki-mesh/aeraki/internal/plugin/thrift"
"github.com/aeraki-mesh/aeraki/internal/plugin/zookeeper"

"istio.io/pkg/log"
)
Expand Down
Expand Up @@ -17,7 +17,7 @@ package bootstrap
import (
"crypto/tls"

"github.com/aeraki-mesh/aeraki/pkg/ca"
"github.com/aeraki-mesh/aeraki/internal/ca"
)

func (s *Server) initRootCA() error {
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions pkg/bootstrap/options.go → internal/bootstrap/options.go
Expand Up @@ -15,8 +15,8 @@
package bootstrap

import (
"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
)

// AerakiArgs provides all of the configuration parameters for the Aeraki service.
Expand Down
18 changes: 9 additions & 9 deletions pkg/bootstrap/server.go → internal/bootstrap/server.go
Expand Up @@ -46,15 +46,15 @@ import (

aerakischeme "github.com/aeraki-mesh/client-go/pkg/clientset/versioned/scheme"

"github.com/aeraki-mesh/aeraki/pkg/controller/istio"
"github.com/aeraki-mesh/aeraki/pkg/controller/kube"
"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/leaderelection"
"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/pkg/util"
"github.com/aeraki-mesh/aeraki/pkg/xds"
"github.com/aeraki-mesh/aeraki/plugin/dubbo"
"github.com/aeraki-mesh/aeraki/plugin/redis"
"github.com/aeraki-mesh/aeraki/internal/controller/istio"
"github.com/aeraki-mesh/aeraki/internal/controller/kube"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/leaderelection"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/plugin/dubbo"
"github.com/aeraki-mesh/aeraki/internal/plugin/redis"
"github.com/aeraki-mesh/aeraki/internal/util"
"github.com/aeraki-mesh/aeraki/internal/xds"
)

var (
Expand Down
Expand Up @@ -17,8 +17,8 @@ package bootstrap
import (
"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/webhook/validation/scheme"
"github.com/aeraki-mesh/aeraki/pkg/webhook/validation/server"
"github.com/aeraki-mesh/aeraki/internal/webhook/validation/scheme"
"github.com/aeraki-mesh/aeraki/internal/webhook/validation/server"
)

func (s *Server) initConfigValidation(args *AerakiArgs) error {
Expand Down
2 changes: 1 addition & 1 deletion pkg/bootstrap/webhook.go → internal/bootstrap/webhook.go
Expand Up @@ -20,7 +20,7 @@ import (
"net/http"
"time"

"github.com/aeraki-mesh/aeraki/pkg/webhook/validation"
"github.com/aeraki-mesh/aeraki/internal/webhook/validation"
)

// initSSecureWebhookServer handles initialization for the HTTPS webhook server.
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Expand Up @@ -19,7 +19,7 @@ import (
"strings"
"time"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"

"istio.io/istio/pkg/security"

Expand All @@ -36,7 +36,7 @@ import (
citadel "istio.io/istio/security/pkg/nodeagent/caclient/providers/citadel"
"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
)

const (
Expand Down
File renamed without changes.
File renamed without changes.
Expand Up @@ -20,7 +20,7 @@ import (

"sigs.k8s.io/controller-runtime/pkg/client"

metaprotocolmodel "github.com/aeraki-mesh/aeraki/pkg/model/metaprotocol"
metaprotocolmodel "github.com/aeraki-mesh/aeraki/internal/model/metaprotocol"

"istio.io/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/controller"
Expand Down
File renamed without changes.
Expand Up @@ -20,7 +20,7 @@ import (

"k8s.io/apimachinery/pkg/api/errors"

"github.com/aeraki-mesh/aeraki/pkg/config/constants"
"github.com/aeraki-mesh/aeraki/internal/config/constants"

"istio.io/pkg/log"
v1 "k8s.io/api/core/v1"
Expand Down
File renamed without changes.
Expand Up @@ -22,8 +22,8 @@ import (

"k8s.io/apimachinery/pkg/api/errors"

"github.com/aeraki-mesh/aeraki/pkg/config/constants"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/config/constants"
"github.com/aeraki-mesh/aeraki/internal/model"

istionapi "istio.io/api/networking/v1alpha3"
networking "istio.io/client-go/pkg/apis/networking/v1alpha3"
Expand Down
File renamed without changes.
Expand Up @@ -37,9 +37,9 @@ import (
"github.com/aeraki-mesh/api/metaprotocol/v1alpha1"
metaprotocol "github.com/aeraki-mesh/client-go/pkg/apis/metaprotocol/v1alpha1"

"github.com/aeraki-mesh/aeraki/pkg/config/constants"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/config/constants"
"github.com/aeraki-mesh/aeraki/internal/model"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
)

const (
Expand Down
Expand Up @@ -15,7 +15,7 @@
package envoyfilter

import (
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

// Generator generates protocol specified envoyfilters
Expand Down
Expand Up @@ -29,7 +29,7 @@ import (
networking "istio.io/api/networking/v1alpha3"
"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

var generatorLog = log.RegisterScope("aeraki-generator", "aeraki generator", 0)
Expand Down
Expand Up @@ -22,7 +22,7 @@ import (

networking "istio.io/api/networking/v1alpha3"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

func Test_inboudEnvoyFilterWorkloadSelector(t *testing.T) {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Expand Up @@ -17,7 +17,7 @@ package protocol_test
import (
"testing"

"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
)

func Test_getLayer7ProtocolFromPortName(t *testing.T) {
Expand Down
File renamed without changes.
Expand Up @@ -32,7 +32,7 @@ import (
"istio.io/istio/pilot/pkg/security/trustdomain"
"istio.io/pkg/log"

authzmodel "github.com/aeraki-mesh/aeraki/plugin/dubbo/authz/model"
authzmodel "github.com/aeraki-mesh/aeraki/internal/plugin/dubbo/authz/model"
)

var (
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Expand Up @@ -22,7 +22,7 @@ import (

"istio.io/istio/pkg/spiffe"

"github.com/aeraki-mesh/aeraki/plugin/dubbo/authz/matcher"
"github.com/aeraki-mesh/aeraki/internal/plugin/dubbo/authz/matcher"
)

type generator interface {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Expand Up @@ -21,8 +21,8 @@ import (

dubbov1alpha1 "github.com/aeraki-mesh/client-go/pkg/clientset/versioned/typed/dubbo/v1alpha1"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/plugin/dubbo/authz/builder"
"github.com/aeraki-mesh/aeraki/internal/model"
"github.com/aeraki-mesh/aeraki/internal/plugin/dubbo/authz/builder"
)

func buildOutboundProxy(context *model.EnvoyFilterContext) *dubbo.DubboProxy {
Expand Down
Expand Up @@ -22,8 +22,8 @@ import (

"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model"
)

var generatorLog = log.RegisterScope("dubbo-generator", "dubbo generator", 0)
Expand Down
2 changes: 1 addition & 1 deletion plugin/dubbo/route.go → internal/plugin/dubbo/route.go
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/golang/protobuf/ptypes/wrappers"
networking "istio.io/api/networking/v1alpha3"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

var (
Expand Down
Expand Up @@ -15,8 +15,8 @@
package kafka

import (
"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model"
)

// Generator defines a kafka envoyfilter Generator
Expand Down
Expand Up @@ -17,7 +17,7 @@ package kafka
import (
kafka "github.com/envoyproxy/go-control-plane/contrib/envoy/extensions/filters/network/kafka_broker/v3"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

func buildOutboundProxy(context *model.EnvoyFilterContext) *kafka.KafkaBroker {
Expand Down
Expand Up @@ -19,7 +19,7 @@ import (
"istio.io/istio/pkg/util/protomarshal"
"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/util/protoconv"
"github.com/aeraki-mesh/aeraki/internal/util/protoconv"

accesslog "github.com/envoyproxy/go-control-plane/envoy/config/accesslog/v3"
envoyconfig "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
Expand Down
Expand Up @@ -36,7 +36,7 @@ import (
userapi "github.com/aeraki-mesh/api/metaprotocol/v1alpha1"
mpclient "github.com/aeraki-mesh/client-go/pkg/apis/metaprotocol/v1alpha1"

"github.com/aeraki-mesh/aeraki/pkg/xds"
"github.com/aeraki-mesh/aeraki/internal/xds"
)

func buildOutboundFilters(host string) []*mpdataplane.MetaProtocolFilter {
Expand Down
Expand Up @@ -20,9 +20,9 @@ import (
istionetworking "istio.io/api/networking/v1alpha3"
"istio.io/pkg/log"

"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/pkg/model/protocol"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model"
"github.com/aeraki-mesh/aeraki/internal/model/protocol"
)

var generatorLog = log.RegisterScope("metaprotocol-generator", "metaprotocol generator", 0)
Expand Down
Expand Up @@ -21,8 +21,8 @@ import (
envoytype "github.com/envoyproxy/go-control-plane/envoy/type/v3"
istionetworking "istio.io/api/networking/v1alpha3"

"github.com/aeraki-mesh/aeraki/pkg/model"
metaprotocolmodel "github.com/aeraki-mesh/aeraki/pkg/model/metaprotocol"
"github.com/aeraki-mesh/aeraki/internal/model"
metaprotocolmodel "github.com/aeraki-mesh/aeraki/internal/model/metaprotocol"
)

const (
Expand Down
Expand Up @@ -19,7 +19,7 @@ import (

metaroute "github.com/aeraki-mesh/meta-protocol-control-plane-api/aeraki/meta_protocol_proxy/config/route/v1alpha"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

func buildInboundRouteConfig(context *model.EnvoyFilterContext,
Expand Down
Expand Up @@ -38,8 +38,8 @@ import (
"istio.io/pkg/log"
corev1 "k8s.io/client-go/kubernetes/typed/core/v1"

"github.com/aeraki-mesh/aeraki/pkg/envoyfilter"
"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
"github.com/aeraki-mesh/aeraki/internal/model"
)

var generatorLog = log.RegisterScope("redis-generator", "redis generator", 0)
Expand Down
Expand Up @@ -17,7 +17,7 @@ package redis
import (
redis "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/redis_proxy/v3"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

func (g *Generator) buildInboundProxy(context *model.EnvoyFilterContext) *redis.RedisProxy {
Expand Down
Expand Up @@ -32,7 +32,7 @@ import (

"github.com/aeraki-mesh/client-go/pkg/apis/redis/v1alpha1"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"

redis "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/redis_proxy/v3"
)
Expand Down
Expand Up @@ -37,7 +37,7 @@ import (
endpoint "github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3"
redis "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/redis_proxy/v3"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

// nolint: funlen,gocyclo
Expand Down
2 changes: 1 addition & 1 deletion plugin/redis/util.go → internal/plugin/redis/util.go
Expand Up @@ -28,7 +28,7 @@ import (

spec "github.com/aeraki-mesh/api/redis/v1alpha1"

"github.com/aeraki-mesh/aeraki/pkg/model"
"github.com/aeraki-mesh/aeraki/internal/model"
)

func getOrCreateIstioMetadata(cluster *cluster.Cluster) *structpb.Struct {
Expand Down

0 comments on commit 3a5033d

Please sign in to comment.