Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mirror validation #233

Merged
merged 1 commit into from
May 25, 2022
Merged

fix: mirror validation #233

merged 1 commit into from
May 25, 2022

Conversation

panniyuyu
Copy link
Contributor

Modify pr #231

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing May 25, 2022 10:16
@mergify mergify bot merged commit 1799402 into aeraki-mesh:master May 25, 2022
@panniyuyu panniyuyu deleted the dev-mirror-validate branch May 25, 2022 12:20
@zhaohuabing
Copy link
Member

This is just a quick-and-dirty fix. We need a ValidationWebhook to check all Aeraki CRDs.

I created an issue to track this: #234

@zhaohuabing
Copy link
Member

A ValidationWebhook has been created to solve this : #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panniyuyu @zhaohuabing