Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: golangci lint gocritic #256

Merged
merged 3 commits into from
Jun 10, 2022
Merged

ci: golangci lint gocritic #256

merged 3 commits into from
Jun 10, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jun 9, 2022 •
edited
Loading

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@Xunzhuo
fix golangci lint: gocritic
475bb64 
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@Xunzhuo
fix golangci lint: unparam
7b3bc4b 
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@mergify mergify bot requested a review from zhaohuabing June 9, 2022 16:04
@Xunzhuo
fix lint
27d6b25 
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
zhaohuabing
zhaohuabing approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 66cc232 into aeraki-mesh:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xunzhuo @zhaohuabing