Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aeraki configmap in namepace if we uninstall aeraki #334

Merged
merged 1 commit into from Apr 14, 2023
Merged

remove aeraki configmap in namepace if we uninstall aeraki #334

merged 1 commit into from Apr 14, 2023

Conversation

tanjunchen
Copy link
Member

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@tanjunchen
remove aeraki configmap in namepace if we uninstall aeraki
9b03116 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
@mergify mergify bot requested a review from zhaohuabing April 14, 2023 05:36
@zhaohuabing
Copy link
Member

LGTM. Thanks for the cleaning up.

@zhaohuabing zhaohuabing merged commit a6925a6 into aeraki-mesh:master Apr 14, 2023
27 checks passed
@tanjunchen tanjunchen deleted the remove-aeraki-configmap branch April 14, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing Awaiting requested review from zhaohuabing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanjunchen @zhaohuabing