Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace map[string]string with sync.Map #363

Merged
merged 1 commit into from Jul 1, 2023
Merged

replace map[string]string with sync.Map #363

merged 1 commit into from Jul 1, 2023

Conversation

xichengliudui
Copy link
Contributor

What this PR does / Why we need it:

remove sync.Mutex

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • [ x ] Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing June 28, 2023 03:31
@xichengliudui xichengliudui reopened this Jun 28, 2023
@xichengliudui
replace map[string]string with sync.Map
b7b7f60 
Signed-off-by: liudui <liuduidui@beyondcent.com>
zhaohuabing
zhaohuabing approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zhaohuabing zhaohuabing merged commit db3b9dc into aeraki-mesh:master Jul 1, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@tanjunchen tanjunchen tanjunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xichengliudui @zhaohuabing @tanjunchen