Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for dubbo source metric destination label unknown #113

Merged
merged 1 commit into from Jul 26, 2023

Conversation

huanghuangzym
Copy link
Member

fix for source metric destination label is unknown aeraki-mesh/aeraki#196

@huanghuangzym huanghuangzym added the WIP Working in progress label Jun 16, 2023
@huanghuangzym huanghuangzym self-assigned this Jun 16, 2023
@huanghuangzym huanghuangzym force-pushed the feat/rsp-header-mutation branch 3 times, most recently from 948e724 to 60331e4 Compare June 27, 2023 08:32
@huanghuangzym huanghuangzym added enhancement New feature or request and removed WIP Working in progress labels Jul 8, 2023
}

if (has_mutation) {
//服务端的response包含了mutation header
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use English to comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,i will fix all chinese comment

Signed-off-by: root <lihuang@alauda.io>
@huanghuangzym huanghuangzym changed the title [wip] fix for dubbo source metric destination label unknown fix for dubbo source metric destination label unknown Jul 25, 2023
@huanghuangzym
Copy link
Member Author

image

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the great feature!

@zhaohuabing zhaohuabing merged commit 57327a0 into master Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants