Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod build ci to 500minute for github action #86

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

huanghuangzym
Copy link
Member

default 3hours
sometime not enough to build envoy,improve it

Signed-off-by: root <lihuang@alauda.io>
@huanghuangzym
Copy link
Member Author

it seemes i do not have enough privalage to request review button
can help to review? @zhaohuabing

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohuabing
Copy link
Member

It takes so long to build envoy.

@zhaohuabing zhaohuabing merged commit 4ccb518 into aeraki-mesh:master Aug 30, 2022
@huanghuangzym
Copy link
Member Author

maybe we should use some build cache to avoid compile all file
pr build is better to increment compile?

@zhaohuabing
Copy link
Member

We should consider using self host runners to build envoy: https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

@huanghuangzym
Copy link
Member Author

We should consider using self host runners to build envoy: https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

i do not have privilige to add self runners in action tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants