Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkings on transaction processing #141

Open
kroggen opened this issue Oct 15, 2020 · 1 comment
Open

Checkings on transaction processing #141

kroggen opened this issue Oct 15, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@kroggen
Copy link
Member

kroggen commented Oct 15, 2020

If we make a transaction with type CALL without payload and to an address that there is no smart contract the engine accepts the transaction.

Example:

https://testnet.aergoscan.io/transaction/CQPK53ftHwgEC8bRBce3vPHvnEZgBJquFXBe3Cv16Vo7/

Notice that the destination account is not a contract and the payload is empty.

If the transaction is a CALL or QUERY then the engine should make these 2 verifications:

  • The destination address must be a smart contract
  • The transaction must have a valid payload (empty payload calls the default function)
@kroggen kroggen added the bug Something isn't working label Mar 14, 2022
@kroggen
Copy link
Member Author

kroggen commented Mar 14, 2022

Here we have a similar case:

https://testnet.aergoscan.io/transaction/6CggiP7zHNCaxJLgTaxUJA3pyj9AJnhtxZfBQiKHgWyG/

Where the payload is valid but the recipient does not exist (is not a contract)

Strangely the transaction is marked as "success"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant