Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing git executable to backend/Dockerfile #14

Merged
merged 1 commit into from Mar 27, 2020

Conversation

aspiers
Copy link
Contributor

@aspiers aspiers commented Feb 18, 2020

The node:10-alpine image is missing git, so the docker-compose up --build fails:

Step 4/8 : RUN npm install
 ---> Running in 81dc09d122ed
npm WARN backend@1.0.0 No repository field.

npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno ENOENT
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/rxaviers/assertion.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

I'm not sure how this ever worked before, but the fix is simple, as explained here:

nodejs/docker-node#586

The node:10-alpine image is missing git, so the docker-compose up --build
fails:

    Step 4/8 : RUN npm install
     ---> Running in 81dc09d122ed
    npm WARN backend@1.0.0 No repository field.

    npm ERR! code ENOENT
    npm ERR! syscall spawn git
    npm ERR! path git
    npm ERR! errno ENOENT
    npm ERR! enoent Error while executing:
    npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/rxaviers/assertion.git
    npm ERR! enoent
    npm ERR! enoent
    npm ERR! enoent spawn git ENOENT
    npm ERR! enoent This is related to npm not being able to find a file.
    npm ERR! enoent

I'm not sure how this ever worked before, but the fix is simple, as
explained here:

  nodejs/docker-node#586
@graup
Copy link
Member

graup commented Mar 27, 2020

This definitely worked before. We don't use any git-style dependencies. I guess a dependency somewhere up the npm module chain changed.
Anyway, thanks for the fix!

@graup graup merged commit d20abd4 into aergoio:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants